Skip to content

Conversation

scc-usc
Copy link

@scc-usc scc-usc commented Oct 2, 2025

No description provided.

Copy link

github-actions bot commented Oct 2, 2025

2025-08-10-LEMMA-EnsembleDTWS.gz.parquet seems to be an Ensemble file - validation not run

Copy link
Contributor

@LucieContamin LucieContamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning,

Thanks for your submission, I ran the validation locally and got an error message (feel free to ignore the col_types warning), please see below. Would it be possible to fix it, please.
Also, I cannot accept the submission without a metadata file, would it be possible to add one, please?

Please let me know if any issues or questions,
Best,
Lucie

Run validation on files: 2025-08-10-LEMMA-EnsembleDTWS.gz.parquet

✅: [valid_round_id_col]: round_id_col name is valid.

✅: [unique_round_id]: round_id column "origin_date" contains a single, unique round ID value.

✅: [match_round_id]: All round_id_col "origin_date" values match submission round_id from file name.

✅: [colnames]: Column names are consistent with expected round task IDs and std column names.

❗: [col_types]: Column data types do not match hub schema.
output_type_id should be "character" not "double".
❌: [valid_vals]: tbl contains invalid values/value combinations.
For example: Column horizon contains invalid
values "44" and "45".

Added metadata for the LEMMA EnsembleDTWS model, including team information, model details, contributors, and methods.
Copy link

github-actions bot commented Oct 7, 2025

Model Metadata

--- LEMMA-EnsembleDTWS.yaml ---

✅: [metadata_schema_exists]: File exists at path 'hub-config/model-metadata-schema.json'.

✅: [metadata_file_exists]: File exists at path 'model-metadata/LEMMA-EnsembleDTWS.yaml'.

✅: [metadata_file_ext]: Metadata file extension is "yml" or "yaml".

✅: [metadata_file_location]: Metadata file directory name matches "model-metadata".

✅: [metadata_matches_schema]: Metadata file contents are consistent with schema specifications.

✅: [metadata_file_name]: Metadata file name matches the model_id specified within the metadata file.

Copy link

2025-08-10-LEMMA-EnsembleDTWS.gz.parquet seems to be an Ensemble file - validation not run

@LucieContamin
Copy link
Contributor

Please find here the validation, please confirm the [flat_projection] are expected and I will merge it.

Thanks,
Lucie

Run validation on files: 2025-08-10-LEMMA-EnsembleDTWS.gz.parquet

✅: [valid_round_id_col]: round_id_col name is valid.

✅: [unique_round_id]: round_id column "origin_date" contains a single, unique round ID value.

✅: [match_round_id]: All round_id_col "origin_date" values match submission round_id from file name.

✅: [colnames]: Column names are consistent with expected round task IDs and std column names.

❗: [col_types]: Column data types do not match hub schema.
output_type_id should be "character" not "double".
✅: [valid_vals]: tbl contains valid values/value combinations.

✅: [rows_unique]: All combinations of task ID column/output_type/output_type_id values are unique.

✅: [req_vals]: Task ID/output type/output_type_id combinations all present.

✅: [value_col_valid]: Values in column value all valid with respect to modeling task config.

✅: [value_col_non_desc]: Quantile or cdf value values increase when ordered by output_type_id.

ℹ: [spl_compound_taskid_set]: No v3 samples found in model output data to check. Skipping check_tbl_spl_compound_taskid_set check.
ℹ: [spl_compound_tid]: No v3 samples found in model output data to check. Skipping check_tbl_spl_compound_tid check.
ℹ: [spl_non_compound_tid]: No v3 samples found in model output data to check. Skipping check_tbl_spl_non_compound_tid check.
ℹ: [spl_n]: No v3 samples found in model output data to check. Skipping check_tbl_spl_n check.
✅: [na_value]: value does not contain NA value.
❗: [flat_projection]: Some projections have a unique value for the whole projection period.
Please verify, for example: 2025-08-10, A-2025-07-29, inc hosp, 34, 0-130, quantile, 0.01; 2025-08-10, A-2025-07-29, inc hosp, 17, 0-130, quantile, 0.01; 2025-08-10, A-2025-07-29, inc hosp, 15, 0-130, quantile, 0.01; 2025-08-10, A-2025-07-29, inc hosp, 15, 0-130, quantile, 0.025; 2025-08-10, B-2025-07-29, inc hosp, 49, 0-130, quantile, 0.01
✅: [cumul_proj]: The cumulative values are not decreasing.

@scc-usc
Copy link
Author

scc-usc commented Oct 10, 2025

Yes. Thanks.

@scc-usc scc-usc closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants